Service Worker: FetchEvent.preventDefault() results in a network error

Service Worker: FetchEvent.preventDefault() results in a network error

Since the default behavior is to fallback to network, preventDefault()
should cause a network error.

As per spec: https://github.com/slightlyoff/ServiceWorker/issues/51
(see commit f022c3a6d)

Also add a test for calling FetchEvent.respondWith() with a rejected
promise; this must also produce a network error.

BUG=432825
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185451

[falken, 2014-11-17 09:33:06]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2014-11-17 09:33:06]

PTAL

[horo, 2014-11-17 11:25:34]

lgtm

[falken, 2014-11-17 13:15:21]

falken@chromium.org changed reviewers:
+ haraken@chromium.org

[falken, 2014-11-17 13:15:21]

+haraken: can you please review core/ and web/?

[haraken, 2014-11-17 13:56:33]

LGTM

[falken, 2014-11-17 14:13:17]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-11-17 14:13:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/733983002/20001

[commit-bot: I haz the power, 2014-11-17 14:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 14:13:53]

Failed to apply patch for Source/web/ServiceWorkerGlobalScopeProxy.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/ServiceWorkerGlobalScopeProxy.cpp
  Hunk #1 FAILED at 81.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/ServiceWorkerGlobalScopeProxy.cpp.rej

Patch:       Source/web/ServiceWorkerGlobalScopeProxy.cpp
Index: Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.cpp
b/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index
75b1e0e5137d34764c5c570f1ec9ddf722a60088..1d7b726215a7be66c45abf67ef10cc8d20924f3c
100644
--- a/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -81,16 +81,17 @@ void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int
eventID, const WebSer
 {
     ASSERT(m_workerGlobalScope);
     RespondWithObserver* observer =
RespondWithObserver::create(m_workerGlobalScope, eventID, webRequest.mode(),
webRequest.frameType());
+    bool defaultPrevented = false;
     if (!RuntimeEnabledFeatures::serviceWorkerOnFetchEnabled()) {
-        observer->didDispatchEvent();
+        observer->didDispatchEvent(defaultPrevented);
         return;
     }
 
     Request* request = Request::create(m_workerGlobalScope, webRequest);
     RefPtrWillBeRawPtr<FetchEvent> fetchEvent(FetchEvent::create(observer,
request));
     fetchEvent->setIsReload(webRequest.isReload());
-    m_workerGlobalScope->dispatchEvent(fetchEvent.release());
-    observer->didDispatchEvent();
+    defaultPrevented =
!m_workerGlobalScope->dispatchEvent(fetchEvent.release());
+    observer->didDispatchEvent(defaultPrevented);
 }
 
 void ServiceWorkerGlobalScopeProxy::dispatchGeofencingEvent(int eventID,
WebGeofencingEventType eventType, const WebString& regionID, const
WebCircularGeofencingRegion& region)

[falken, 2014-11-17 14:46:59]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-11-17 14:47:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/733983002/40001

[commit-bot: I haz the power, 2014-11-17 16:19:09]

Committed patchset #3 (id:40001) as 185451