Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 733963004: Make BBH parameter to SkRecordComputeLayers and SkRecordFillBounds optional (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make BBH parameter to SkRecordComputeLayers and SkRecordFillBounds optional Chromium creates a picture to contain their picture pile in order to use MultiPictureDraw. They currently do not create a bounding box for that picture but I still need layer information for it. This change allows Chromium to continue without a BBH but still have layer information. In the future, the brute force BBH might be suitable for their use case. Please see gpu_raster_worker_pool.cc in (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/721883002/) for where this is happening in Chromium. Committed: https://skia.googlesource.com/skia/+/8910879098694c61267e21789d933928c1b7995e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robertphillips
6 years, 1 month ago (2014-11-17 15:00:02 UTC) #2
mtklein
lgtm
6 years, 1 month ago (2014-11-17 15:20:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733963004/1
6 years, 1 month ago (2014-11-17 15:44:59 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 16:16:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8910879098694c61267e21789d933928c1b7995e

Powered by Google App Engine
This is Rietveld 408576698