chrome/browser/password_manager/chrome_password_manager_client.h - Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Vaclav's review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 1cd35819d2a278421b1b0bf6961c1cfac4dfc865..bb27f13ad2614ca6f80c3e5c1f4b3c8a4e4fe9b3 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -65,6 +65,7 @@ class ChromePasswordManagerClient

void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;

void LogSavePasswordProgress(const std::string& text) override;

bool IsLoggingActive() const override;

+ bool WasLastNavigationHTTPError() const override;

// Hides any visible generation UI.

void HidePasswordGenerationPopup();