Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 733943004: Remove Text.replaceWholeText() (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
chrishtr
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1596 lines) Patch
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext01.js View 1 chunk +0 lines, -118 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext01.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext01-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext02.js View 1 chunk +0 lines, -114 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext02.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext02-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext03.js View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext03.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext03-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext04.js View 1 chunk +0 lines, -109 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext04.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext04-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext05.js View 1 chunk +0 lines, -123 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext05.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext05-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext06.js View 1 chunk +0 lines, -133 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext06.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext06-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext07.js View 1 chunk +0 lines, -139 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext07.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext07-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext08.js View 1 chunk +0 lines, -126 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext08.xhtml View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/textreplacewholetext08-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/dom/Text/replaceWholeText.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/Text/replaceWholeText-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/Text/script-tests/replaceWholeText.js View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/fast/dom/text-api-arguments.html View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/dom/text-api-arguments-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/storage/storage-detached-iframe.html View 1 chunk +2 lines, -2 lines 2 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Text.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-18 18:40:54 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/733943004/diff/20001/LayoutTests/fast/storage/storage-detached-iframe.html File LayoutTests/fast/storage/storage-detached-iframe.html (left): https://codereview.chromium.org/733943004/diff/20001/LayoutTests/fast/storage/storage-detached-iframe.html#oldcode20 LayoutTests/fast/storage/storage-detached-iframe.html:20: first_attr_value_replaced = first_attr.firstChild.replaceWholeText(undefined, undefined, undefined, undefined); Was this ...
6 years, 1 month ago (2014-11-18 18:43:52 UTC) #3
philipj_slow
https://codereview.chromium.org/733943004/diff/20001/LayoutTests/fast/storage/storage-detached-iframe.html File LayoutTests/fast/storage/storage-detached-iframe.html (left): https://codereview.chromium.org/733943004/diff/20001/LayoutTests/fast/storage/storage-detached-iframe.html#oldcode20 LayoutTests/fast/storage/storage-detached-iframe.html:20: first_attr_value_replaced = first_attr.firstChild.replaceWholeText(undefined, undefined, undefined, undefined); On 2014/11/18 18:43:52, ...
6 years, 1 month ago (2014-11-18 19:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733943004/20001
6 years, 1 month ago (2014-11-18 19:04:01 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 19:07:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185541

Powered by Google App Engine
This is Rietveld 408576698