Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 733923003: Ignore any import error for upload.py (Closed)

Created:
6 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Ignore any import error for upload.py BUG=none TBR=jrobbins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/upload.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
jochen (gone - plz use gerrit)
6 years, 1 month ago (2014-11-17 20:45:32 UTC) #1
jochen (gone - plz use gerrit)
+jrobbins
6 years, 1 month ago (2014-11-17 20:49:14 UTC) #3
Jason Robbins -- corp
Can you explain more about what motivated this change? What error were you seeing?
6 years, 1 month ago (2014-11-17 23:15:52 UTC) #4
jochen (gone - plz use gerrit)
I get this error: $ git cl upload -t updates Traceback (most recent call last): ...
6 years, 1 month ago (2014-11-18 08:35:11 UTC) #5
jochen (gone - plz use gerrit)
ping?
6 years, 1 month ago (2014-11-19 08:46:06 UTC) #6
Jason Robbins -- corp
lgtm. I assume in this case the user just doesn't get to use their keyring, ...
6 years, 1 month ago (2014-11-19 20:39:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733923003/1
6 years, 1 month ago (2014-11-19 20:41:18 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-19 20:41:21 UTC) #12
M-A Ruel
lgtm
6 years, 1 month ago (2014-11-19 20:43:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733923003/1
6 years, 1 month ago (2014-11-19 20:43:18 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 20:45:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293010

Powered by Google App Engine
This is Rietveld 408576698