|
|
Chromium Code Reviews|
Created:
6 years, 1 month ago by jochen (gone - plz use gerrit) Modified:
6 years, 1 month ago CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org Project:
tools Visibility:
Public. |
DescriptionIgnore any import error for upload.py
BUG=none
TBR=jrobbins@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293010
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
jochen@chromium.org changed reviewers: + jrobbins@chromium.org
+jrobbins
Can you explain more about what motivated this change? What error were you seeing?
I get this error:
$ git cl upload -t updates
Traceback (most recent call last):
File "/chrome/trunk/tools/depot_tools/git_cl.py", line 35, in <module>
from third_party import upload
File "/chrome/trunk/tools/depot_tools/third_party/upload.py", line 71, in
<module>
import keyring
File "/usr/lib/python2.7/dist-packages/keyring/__init__.py", line 12, in
<module>
from .core import (set_keyring, get_keyring, set_password, get_password,
File "/usr/lib/python2.7/dist-packages/keyring/core.py", line 180, in <module>
init_backend()
File "/usr/lib/python2.7/dist-packages/keyring/core.py", line 59, in
init_backend
set_keyring(load_config() or _get_best_keyring())
File "/usr/lib/python2.7/dist-packages/keyring/core.py", line 67, in
_get_best_keyring
keyrings = backend.get_all_keyring()
File "/usr/lib/python2.7/dist-packages/keyring/util/__init__.py", line 24, in
wrapper
func.always_returns = func(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/keyring/backend.py", line 127, in
get_all_keyring
exceptions=TypeError))
File "/usr/lib/python2.7/dist-packages/keyring/util/__init__.py", line 35, in
suppress_exceptions
for callable in callables:
File "/usr/lib/python2.7/dist-packages/keyring/backend.py", line 119, in
is_class_viable
keyring_cls.priority
File "/usr/lib/python2.7/dist-packages/keyring/util/properties.py", line 22,
in __get__
return self.fget.__get__(None, owner)()
File "/usr/lib/python2.7/dist-packages/keyring/util/XDG.py", line 18, in
wrapper
return func(*args, **kwargs) * self.multiplier
File "/usr/lib/python2.7/dist-packages/keyring/backends/SecretService.py",
line 31, in priority
bus = secretstorage.dbus_init()
File "/usr/lib/python2.7/dist-packages/secretstorage/__init__.py", line 46, in
dbus_init
return dbus.SessionBus()
File "/usr/lib/python2.7/dist-packages/dbus/_dbus.py", line 211, in __new__
mainloop=mainloop)
File "/usr/lib/python2.7/dist-packages/dbus/_dbus.py", line 100, in __new__
bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
File "/usr/lib/python2.7/dist-packages/dbus/bus.py", line 122, in __new__
bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoServer: Failed to
connect to socket /tmp/dbus-aJu5J7HUmz: Connection refused
ping?
jrobbins@google.com changed reviewers: + jrobbins@google.com
lgtm. I assume in this case the user just doesn't get to use their keyring, which should be no loss if it wasn't going to work anyway.
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733923003/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by jochen@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733923003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293010 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
