Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 7338011: Linux Cert manager: improve PKCS #12 import error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by mattm
Modified:
2 years, 9 months ago
Reviewers:
wtc
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Linux Cert manager: improve PKCS #12 import error messages.

BUG=76275
TEST=try to import a corrupt or unsupported PKCS #12 file.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92306

Patch Set 1 #

Total comments: 7

Patch Set 2 : review changes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -14 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 1 chunk +16 lines, -7 lines 0 comments 0 errors Download
M net/base/cert_database_nss_unittest.cc View 1 2 chunks +31 lines, -0 lines 0 comments 0 errors Download
M net/base/net_error_list.h View 1 1 chunk +9 lines, -0 lines 0 comments ? errors Download
M net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp View 1 1 chunk +24 lines, -7 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
mattm
2 years, 9 months ago #1
wtc
LGTM! http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd#newcode3354 chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file. Does an incorrect ...
2 years, 9 months ago #2
mattm
http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd#newcode3354 chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file. On 2011/07/12 20:22:38, wtc ...
2 years, 9 months ago #3
wtc
LGTM.
2 years, 9 months ago #4
wtc
2 years, 9 months ago #5
http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file.
On 2011/07/12 22:56:36, mattm wrote:
> On 2011/07/12 20:22:38, wtc wrote:
> > Does an incorrect password cause the invalid MAC error?
> 
> Based on the SEC_ERROR_PKCS12_INVALID_MAC entry in:
> http://www.mozilla.org/projects/security/pki/nss/ref/ssl/sslerr.html

Thank you for the explanation.

I found this NSS code, which also says that an incorrect
password may cause the invalid MAC error:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/pkcs12/p...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6