Linux Cert manager: improve PKCS #12 import error messages.

Linux Cert manager: improve PKCS #12 import error messages.

BUG=76275
TEST=try to import a corrupt or unsupported PKCS #12 file.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92306

[wtc, 2011-07-12 20:22:37]

LGTM!

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file.
Does an incorrect password cause the invalid MAC error?

http://codereview.chromium.org/7338011/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

http://codereview.chromium.org/7338011/diff/1/net/base/net_error_list.h#newco...
net/base/net_error_list.h:562: NET_ERROR(PKCS12_IMPORT_INVALID, -708)
Maybe PKCS12_IMPORT_INVALID_FILE or PKCS12_IMPORT_INVALID_FORMAT
would be clearer?

http://codereview.chromium.org/7338011/diff/1/net/third_party/mozilla_securit...
File net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp (right):

http://codereview.chromium.org/7338011/diff/1/net/third_party/mozilla_securit...
net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp:231: int port_error =
PORT_GetError();
Please name this variable just 'error', or 'nss_error'.

[mattm, 2011-07-12 22:56:36]

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file.
On 2011/07/12 20:22:38, wtc wrote:
> Does an incorrect password cause the invalid MAC error?

Based on the SEC_ERROR_PKCS12_INVALID_MAC entry in:
http://www.mozilla.org/projects/security/pki/nss/ref/ssl/sslerr.html

Dunno if it's accurate though.  The tests I've done with incorrect passwords
return the SEC_ERROR_BAD_PASSWORD error, but perhaps it requires some certain
conditions to occur.

http://codereview.chromium.org/7338011/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

http://codereview.chromium.org/7338011/diff/1/net/base/net_error_list.h#newco...
net/base/net_error_list.h:562: NET_ERROR(PKCS12_IMPORT_INVALID, -708)
On 2011/07/12 20:22:38, wtc wrote:
> Maybe PKCS12_IMPORT_INVALID_FILE or PKCS12_IMPORT_INVALID_FORMAT
> would be clearer?

Done.

http://codereview.chromium.org/7338011/diff/1/net/third_party/mozilla_securit...
File net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp (right):

http://codereview.chromium.org/7338011/diff/1/net/third_party/mozilla_securit...
net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp:231: int port_error =
PORT_GetError();
On 2011/07/12 20:22:38, wtc wrote:
> Please name this variable just 'error', or 'nss_error'.

Done.

[wtc, 2011-07-13 00:47:33]

LGTM.

[wtc, 2011-07-13 00:51:07]

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7338011/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:3354: Incorrect password or corrupt file.
On 2011/07/12 22:56:36, mattm wrote:
> On 2011/07/12 20:22:38, wtc wrote:
> > Does an incorrect password cause the invalid MAC error?
> 
> Based on the SEC_ERROR_PKCS12_INVALID_MAC entry in:
> http://www.mozilla.org/projects/security/pki/nss/ref/ssl/sslerr.html

Thank you for the explanation.

I found this NSS code, which also says that an incorrect
password may cause the invalid MAC error:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/pkcs12/p...