Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: cc/resources/tile_manager_perftest.cc

Issue 733773005: cc: GPU rasterize tiles synchronously in PrepareToDraw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove redundant completed_tasks_.clear() Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager_perftest.cc
diff --git a/cc/resources/tile_manager_perftest.cc b/cc/resources/tile_manager_perftest.cc
index 7b096bd261b602e409a7e1deddf775960066bcd4..0c860eeb714ebd1560a1aa26680b2ca4f42b3a23 100644
--- a/cc/resources/tile_manager_perftest.cc
+++ b/cc/resources/tile_manager_perftest.cc
@@ -39,12 +39,24 @@ class FakeRasterizerImpl : public Rasterizer, public RasterizerTaskClient {
// Overridden from Rasterizer:
void SetClient(RasterizerClient* client) override {}
void Shutdown() override {}
+ void RunTasks(RasterTaskQueue* queue) override {
+ for (auto& item : queue->items) {
+ RasterTask* task = item.task;
+
+ task->WillSchedule();
+ task->ScheduleOnOriginThread(this);
+ task->DidSchedule();
+
+ task->WillRun();
+ task->RunOnWorkerThread();
+ task->DidRun();
+
+ completed_tasks_.push_back(task);
+ }
+ }
void ScheduleTasks(RasterTaskQueue* queue) override {
- for (RasterTaskQueue::Item::Vector::const_iterator it =
- queue->items.begin();
- it != queue->items.end();
- ++it) {
- RasterTask* task = it->task;
+ for (auto& item : queue->items) {
+ RasterTask* task = item.task;
task->WillSchedule();
task->ScheduleOnOriginThread(this);
@@ -54,11 +66,7 @@ class FakeRasterizerImpl : public Rasterizer, public RasterizerTaskClient {
}
}
void CheckForCompletedTasks() override {
- for (RasterTask::Vector::iterator it = completed_tasks_.begin();
- it != completed_tasks_.end();
- ++it) {
- RasterTask* task = it->get();
-
+ for (auto& task : completed_tasks_) {
task->WillComplete();
task->CompleteOnOriginThread(this);
task->DidComplete();

Powered by Google App Engine
This is Rietveld 408576698