Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 733763003: Remove #include of compiler_specific.h from macros.h. (Closed)

Created:
6 years, 1 month ago by Peter Kasting
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, sadrul, Ian Vollick, jam, timvolodine, sievers+watch_chromium.org, jbauman+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, danakj+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove #include of compiler_specific.h from macros.h. Include it directly in files which want it. BUG=none TEST=none Committed: https://crrev.com/5cd8444c9a4561ad0c6e82a28b6926c8327c4e55 Cr-Commit-Position: refs/heads/master@{#305137}

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Another Linux fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ash/accelerators/accelerator_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/logging_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/macros.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/bluetooth/web_bluetooth_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/battery_status/battery_status_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/x/x11_foreign_window_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/x/x11_foreign_window_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer_tree_owner.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
6 years, 1 month ago (2014-11-18 20:42:45 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-20 22:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733763003/40001
6 years, 1 month ago (2014-11-20 22:22:07 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 01:37:31 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 01:38:52 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5cd8444c9a4561ad0c6e82a28b6926c8327c4e55
Cr-Commit-Position: refs/heads/master@{#305137}

Powered by Google App Engine
This is Rietveld 408576698