fpdfsdk/src/javascript/global.cpp - Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/global.cpp

Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Tweaking comments for implicit and explicit string conversions. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/global.cpp

diff --git a/fpdfsdk/src/javascript/global.cpp b/fpdfsdk/src/javascript/global.cpp

index 295a8d49afe698583b8a40c923d0df183efae42f..1d61571c8b161db84fec1e0529df416ea0892cf7 100644

--- a/fpdfsdk/src/javascript/global.cpp

+++ b/fpdfsdk/src/javascript/global.cpp

@@ -341,7 +341,7 @@ void global_alternate::ObjectToArray(v8::Handle<v8::Object> pObj, CJS_GlobalVari

CFX_WideString ws = JS_ToString(JS_GetArrayElemnet(pKeyList, i));

CFX_ByteString sKey = ws.UTF8Encode();

- v8::Handle<v8::Value> v = JS_GetObjectElement(isolate, pObj, (const wchar_t*)(FX_LPCWSTR)ws);

+ v8::Handle<v8::Value> v = JS_GetObjectElement(isolate, pObj, ws.c_str());

FXJSVALUETYPE vt = GET_VALUE_TYPE(v);

switch (vt)

{

« core/include/fxcrt/fx_string.h ('K') | « fpdfsdk/src/javascript/app.cpp ('k') | fpdfsdk/src/javascript/util.cpp » ('j') | no next file with comments »