core/src/fxcrt/fxcrt_platforms.cpp - Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fxcrt_platforms.cpp

Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Simplified GetAttrValue to just assign *pValue and to share code. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/fxcrt_platforms.cpp

diff --git a/core/src/fxcrt/fxcrt_platforms.cpp b/core/src/fxcrt/fxcrt_platforms.cpp

index e14e36207948f5cee40aeff019306ecb03cbe698..1c47ee6c9b71f247335668c1c10d0f01a72735be 100644

--- a/core/src/fxcrt/fxcrt_platforms.cpp

+++ b/core/src/fxcrt/fxcrt_platforms.cpp

@@ -56,7 +56,7 @@ FX_BOOL CFXCRT_FileAccess_CRT::Open(FX_WSTR fileName, FX_DWORD dwMode)

}

CFX_WideString strMode;

FXCRT_GetFileModeString(dwMode, strMode);

- m_hFile = FXSYS_wfopen(fileName.GetPtr(), (FX_LPCWSTR)strMode);

+ m_hFile = FXSYS_wfopen(fileName.GetPtr(), strMode.c_str());

return m_hFile != NULL;

}

void CFXCRT_FileAccess_CRT::Close()

« no previous file with comments | « core/src/fxcrt/fx_xml_parser.cpp ('k') | fpdfsdk/include/javascript/JS_Define.h » ('j') | no next file with comments »