core/src/fxcrt/fx_extension.cpp - Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_extension.cpp

Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Simplified GetAttrValue to just assign *pValue and to share code. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/fx_extension.cpp

diff --git a/core/src/fxcrt/fx_extension.cpp b/core/src/fxcrt/fx_extension.cpp

index 7ff6b062b40dd2357340c4573178c637256cf6a7..6e82ab3d5c703632e2c1478c05c51b7a10d0077e 100644

--- a/core/src/fxcrt/fx_extension.cpp

+++ b/core/src/fxcrt/fx_extension.cpp

@@ -146,7 +146,7 @@ FX_FLOAT FXSYS_strtof(FX_LPCSTR pcsStr, FX_INT32 iLength, FX_INT32 *pUsedLen)

iLength = (FX_INT32)FXSYS_strlen(pcsStr);

}

CFX_WideString ws = CFX_WideString::FromLocal(pcsStr, iLength);

- return FXSYS_wcstof((FX_LPCWSTR)ws, iLength, pUsedLen);

+ return FXSYS_wcstof(ws.c_str(), iLength, pUsedLen);

}

FX_FLOAT FXSYS_wcstof(FX_LPCWSTR pwsStr, FX_INT32 iLength, FX_INT32 *pUsedLen)

{

« no previous file with comments | « core/src/fxcrt/fx_basic_buffer.cpp ('k') | core/src/fxcrt/fx_xml_parser.cpp » ('j') | no next file with comments »