core/src/fpdfapi/fpdf_font/fpdf_font.cpp - Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Simplified GetAttrValue to just assign *pValue and to share code. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

index 36b6ce2b5bf2325d4c92dc6a727567210da6c275..dd646ca113848be0c0c46595de99295ed329c088 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

@@ -228,7 +228,7 @@ CFX_ByteString CPDF_Font::EncodeString(const CFX_WideString& str) const

CFX_ByteString result;

int src_len = str.GetLength();

FX_LPSTR dest_buf = result.GetBuffer(src_len * 2);

- FX_LPCWSTR src_buf = str;

+ FX_LPCWSTR src_buf = str.c_str();

int dest_pos = 0;

for (int src_pos = 0; src_pos < src_len; src_pos ++) {

FX_DWORD charcode = CharCodeFromUnicode(src_buf[src_pos]);

« no previous file with comments | « core/include/fxcrt/fx_string.h ('k') | core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp » ('j') | no next file with comments »