Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

fpdfsdk/src/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fsdk_baseannot.h"
 #include "../include/fsdk_baseform.h"
@@ skipping 1056 matching lines @@
                 
                 pEdit->Initialize();
                 
                 if (sValue)
                         pEdit->SetText(sValue);
                 else
                 {
                         FX_INT32 nCurSel = pField->GetSelectedIndex(0);
 
                         if (nCurSel < 0)
-                                pEdit->SetText((FX_LPCWSTR)pField->GetValue());
+                                pEdit->SetText(pField->GetValue().c_str());
                         else
-                                pEdit->SetText((FX_LPCWSTR)pField->GetOptionLabel(nCurSel));
+                                pEdit->SetText(pField->GetOptionLabel(nCurSel).c_str());
                 }
 
                 CPDF_Rect rcContent = pEdit->GetContentRect();
 
                 CFX_ByteString sEdit = CPWL_Utils::GetEditAppStream(pEdit,CPDF_Point(0.0f,0.0f));
                 if (sEdit.GetLength() > 0)
                 {
                         sBody << "/Tx BMC\n" << "q\n";
                         if (rcContent.Width() > rcEdit.Width() ||
                                 rcContent.Height() > rcEdit.Height())
@@ skipping 64 matching lines @@
                         FX_BOOL bSelected = FALSE;                              
                         for (FX_INT32 j=0; j<nSelCount; j++)
                         {
                                 if (pField->GetSelectedIndex(j) == i)
                                 {
                                         bSelected = TRUE;
                                         break;
                                 }
                         }
 
-                        pEdit->SetText((FX_LPCWSTR)pField->GetOptionLabel(i));
+                        pEdit->SetText(pField->GetOptionLabel(i).c_str());
 
                         CPDF_Rect rcContent = pEdit->GetContentRect();
                         FX_FLOAT fItemHeight = rcContent.Height();
 
                         if (bSelected)
                         {
                                 CPDF_Rect rcItem = CPDF_Rect(rcClient.left,fy-fItemHeight,rcClient.right,fy);
                                 sList << "q\n" << CPWL_Utils::GetColorAppStream(CPWL_Color(COLORTYPE_RGB,0,51.0f/255.0f,113.0f/255.0f),TRUE)
                                         << rcItem.left << " " << rcItem.bottom << " " << rcItem.Width() << " " << rcItem.Height() << " re f\n" << "Q\n";
 
@@ skipping 98 matching lines @@
                 if (IsFloatZero(fFontSize))
                         pEdit->SetAutoFontSize(TRUE);
                 else
                         pEdit->SetFontSize(fFontSize);
 
                 pEdit->Initialize();
                 
                 if (sValue)
                         pEdit->SetText(sValue);
                 else
-                        pEdit->SetText((FX_LPCWSTR)pField->GetValue());
+                        pEdit->SetText(pField->GetValue().c_str());
 
                 CPDF_Rect rcContent = pEdit->GetContentRect();
 
                 CFX_ByteString sEdit = CPWL_Utils::GetEditAppStream(pEdit,CPDF_Point(0.0f,0.0f),
                                                                                                                                         NULL,!bCharArray,subWord);
 
                 if (sEdit.GetLength() > 0)
                 {
                         sBody << "/Tx BMC\n" << "q\n";
                         if (rcContent.Width() > rcClient.Width() ||
@@ skipping 981 matching lines @@
 
         FX_LPBYTE pBuffer = textBuf.GetBuffer();
         FX_STRSIZE nBufSize = textBuf.GetLength();
         
         if (bUrlEncoded)
         {
                 if(!FDFToURLEncodedData(pBuffer, nBufSize))
                         return FALSE;
         }
 
-        pEnv->JS_docSubmitForm(pBuffer, nBufSize, (FX_LPCWSTR)csDestination);
+        pEnv->JS_docSubmitForm(pBuffer, nBufSize, csDestination.c_str());
         
         return TRUE;
 }
 
 void CPDFSDK_InterForm::DoFDFBuffer(CFX_ByteString sBuffer)
 {
         ASSERT(m_pDocument != NULL);
 
         if (CFDF_Document *pFDFDocument = CFDF_Document::ParseMemory((const unsigned char *)sBuffer.GetBuffer(sBuffer.GetLength()), sBuffer.GetLength()))
         {                                               
@@ skipping 130 matching lines @@
 
         FX_LPBYTE pBuffer = FdfBuffer.GetBuffer();
         FX_STRSIZE nBufSize = FdfBuffer.GetLength();
         
         if (bUrlEncoded)
         {
                 if(!FDFToURLEncodedData(pBuffer, nBufSize))
                         return FALSE;
         }
 
-        pEnv->JS_docSubmitForm(pBuffer, nBufSize, (FX_LPCWSTR)sDestination);
+        pEnv->JS_docSubmitForm(pBuffer, nBufSize, sDestination.c_str());
         
         if (bUrlEncoded && pBuffer)
         {
                 FX_Free(pBuffer);
                 pBuffer = NULL; 
         }
 
         return TRUE;
 }
 
@@ skipping 649 matching lines @@
 
         CPDF_Annot* pPDFAnnot = pAnnot->GetPDFAnnot();
         ASSERT(pPDFAnnot != NULL);
 
         CPDF_Rect rcAnnot;
         pPDFAnnot->GetRect(rcAnnot);
 
         return rcAnnot;
 }