Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h" 
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 75 matching lines @@
         pArray->Add(pObjDef);
         return pArray->GetSize()-1;
 }
 
 int JS_DefineObjMethod(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sMethodName, v8::FunctionCallback pMethodCall, unsigned nParamNum)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_WideString ws = CFX_WideString((FX_LPCWSTR)sMethodName);
+        CFX_WideString ws = CFX_WideString(sMethodName);
         CFX_ByteString bsMethodName = ws.UTF8Encode();
 
         CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(0);
         if(!pArray) return 0;
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->Set(v8::String::NewFromUtf8(isolate, FX_LPCSTR(bsMethodName)), v8::FunctionTemplate::New(isolate, pMethodCall), v8::ReadOnly);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
 int JS_DefineObjProperty(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sPropName, v8::AccessorGetterCallback pPropGet, v8::AccessorSetterCallback pPropPut)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_WideString ws = CFX_WideString((FX_LPCWSTR)sPropName);
+        CFX_WideString ws = CFX_WideString(sPropName);
         CFX_ByteString bsPropertyName = ws.UTF8Encode();
 
         CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(0);
         if(!pArray) return 0;
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->SetAccessor(v8::String::NewFromUtf8(isolate, FX_LPCSTR(bsPropertyName)), pPropGet, pPropPut);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
@@ skipping 19 matching lines @@
 
 int JS_DefineObjConst(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sConstName, v8::Handle<v8::Value> pDefault)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
         CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(0);
         if(!pArray) return 0;
 
-        CFX_WideString ws = CFX_WideString((FX_LPCWSTR)sConstName);
+        CFX_WideString ws = CFX_WideString(sConstName);
         CFX_ByteString bsConstName = ws.UTF8Encode();
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->Set(isolate, FX_LPCSTR(bsConstName), pDefault);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
@@ skipping 14 matching lines @@
         static v8::Persistent<v8::ObjectTemplate> gloabalObjectTemplate;
         return gloabalObjectTemplate;
 }
 
 int JS_DefineGlobalMethod(IJS_Runtime* pJSRuntime, const wchar_t* sMethodName, v8::FunctionCallback pMethodCall, unsigned nParamNum)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_WideString ws = CFX_WideString((FX_LPCWSTR)sMethodName);
+        CFX_WideString ws = CFX_WideString(sMethodName);
         CFX_ByteString bsMethodName = ws.UTF8Encode();
 
         v8::Local<v8::FunctionTemplate> funTempl = v8::FunctionTemplate::New(isolate, pMethodCall);
         v8::Local<v8::ObjectTemplate> objTemp;
 
         v8::Persistent<v8::ObjectTemplate>& globalObjTemp = _getGlobalObjectTemplate(pJSRuntime);
         if(globalObjTemp.IsEmpty())
                 objTemp = v8::ObjectTemplate::New(isolate);
         else
                 objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, globalObjTemp);
         objTemp->Set(v8::String::NewFromUtf8(isolate, FX_LPCSTR(bsMethodName)), funTempl, v8::ReadOnly);
 
         globalObjTemp.Reset(isolate,objTemp);
 
         return 0;
 }
 
 int JS_DefineGlobalConst(IJS_Runtime* pJSRuntime, const wchar_t* sConstName, v8::Handle<v8::Value> pDefault)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_WideString ws = CFX_WideString((FX_LPCWSTR)sConstName);
+        CFX_WideString ws = CFX_WideString(sConstName);
         CFX_ByteString bsConst= ws.UTF8Encode();
 
         v8::Local<v8::ObjectTemplate> objTemp;
 
         v8::Persistent<v8::ObjectTemplate>& globalObjTemp = _getGlobalObjectTemplate(pJSRuntime);
         if(globalObjTemp.IsEmpty())
                 objTemp = v8::ObjectTemplate::New(isolate);
         else
                 objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, globalObjTemp);
         objTemp->Set(v8::String::NewFromUtf8(isolate, FX_LPCSTR(bsConst)), pDefault, v8::ReadOnly);
@@ skipping 808 matching lines @@
 {
         return d != d;
 }
 
 double JS_LocalTime(double d)
 {
         return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 //JavaScript time implement End.