Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: fpdfsdk/src/javascript/app.cpp

Issue 733693003: Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Simplified GetAttrValue to just assign *pValue and to share code. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/PublicMethods.cpp ('k') | fpdfsdk/src/javascript/global.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/javascript/JavaScript.h" 7 #include "../../include/javascript/JavaScript.h"
8 #include "../../include/javascript/IJavaScript.h" 8 #include "../../include/javascript/IJavaScript.h"
9 #include "../../include/javascript/JS_Define.h" 9 #include "../../include/javascript/JS_Define.h"
10 #include "../../include/javascript/JS_Object.h" 10 #include "../../include/javascript/JS_Object.h"
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 806
807 807
808 808
809 CJS_Runtime* pRuntime = pContext->GetJSRuntime(); 809 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
810 ASSERT(pRuntime != NULL); 810 ASSERT(pRuntime != NULL);
811 811
812 CPDFDoc_Environment* pApp = pContext->GetReaderApp(); 812 CPDFDoc_Environment* pApp = pContext->GetReaderApp();
813 ASSERT(pApp != NULL); 813 ASSERT(pApp != NULL);
814 814
815 pRuntime->BeginBlock(); 815 pRuntime->BeginBlock();
816 » pApp->JS_docmailForm(NULL, 0, bUI, (FX_LPCWSTR)cTo, (FX_LPCWSTR)cSubject , (FX_LPCWSTR)cCc, (FX_LPCWSTR)cBcc, (FX_LPCWSTR)cMsg); 816 » pApp->JS_docmailForm(NULL, 0, bUI, cTo.c_str(), cSubject.c_str(), cCc.c_ str(), cBcc.c_str(), cMsg.c_str());
817 //////////////////////////////////////////////////////////////////////// /////////////////////// 817 //////////////////////////////////////////////////////////////////////// ///////////////////////
818 pRuntime->EndBlock(); 818 pRuntime->EndBlock();
819 819
820 //return bRet; 820 //return bRet;
821 return FALSE; 821 return FALSE;
822 } 822 }
823 823
824 FX_BOOL app::launchURL(OBJ_METHOD_PARAMS) 824 FX_BOOL app::launchURL(OBJ_METHOD_PARAMS)
825 { 825 {
826 if (IsSafeMode(cc)) return TRUE; 826 if (IsSafeMode(cc)) return TRUE;
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 FX_BOOL app::media(OBJ_PROP_PARAMS) 1113 FX_BOOL app::media(OBJ_PROP_PARAMS)
1114 { 1114 {
1115 return FALSE; 1115 return FALSE;
1116 } 1116 }
1117 1117
1118 FX_BOOL app::execDialog(OBJ_METHOD_PARAMS) 1118 FX_BOOL app::execDialog(OBJ_METHOD_PARAMS)
1119 { 1119 {
1120 return TRUE; 1120 return TRUE;
1121 } 1121 }
1122 1122
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/PublicMethods.cpp ('k') | fpdfsdk/src/javascript/global.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698