Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 733633003: Remove some unreliable usages of setTimeout( ,0) from layout tests (Closed)

Created:
6 years, 1 month ago by Nate Chapin
Modified:
6 years, 1 month ago
Reviewers:
dglazkov
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove some unreliable usages of setTimeout( ,0) from layout tests These are flaky after https://codereview.chromium.org/467153003, which made a 0ms setTimeout() no longer be a minimum 1ms delay. These tests all depend on doing work during or after the load event, but attempt to do so in ways that aren't strictly guaranteed to meet that requirement. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M LayoutTests/fast/loader/resources/unschedule-relayout-after-unload-target.html View 1 chunk +5 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/images/jpeg-partial-load.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/images/png-partial-load.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/images/png-partial-load-no-alpha.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/images/webp-partial-load.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nate Chapin
6 years, 1 month ago (2014-11-14 22:50:40 UTC) #2
dglazkov
lgtm
6 years, 1 month ago (2014-11-14 22:52:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733633003/1
6 years, 1 month ago (2014-11-14 22:53:13 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 00:14:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185398

Powered by Google App Engine
This is Rietveld 408576698