Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 733483003: Add a cctest for using a C++ FunctionCallback as an Object.observe observer (Closed)

Created:
6 years, 1 month ago by adamk
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Add a cctest for using a C++ FunctionCallback as an Object.observe observer R=rossberg@chromium.org BUG=v8:3076 LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/58839390c3001a90e387c4211620e38ca8c53717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M test/cctest/test-object-observe.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
6 years, 1 month ago (2014-11-14 22:12:19 UTC) #1
rossberg
lgtm
6 years, 1 month ago (2014-11-17 07:34:47 UTC) #2
adamk
6 years, 1 month ago (2014-11-17 20:29:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58839390c3001a90e387c4211620e38ca8c53717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698