Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: components/password_manager/core/common/password_manager_ui.cc

Issue 733463003: Show user credentials chooser bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Aura compilation Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.cc
diff --git a/components/password_manager/core/common/password_manager_ui.cc b/components/password_manager/core/common/password_manager_ui.cc
index b76394ed7f1a79662850d375e45ab29fd1a63903..12ff5972eac6b7184de00328500852c34e4c7e96 100644
--- a/components/password_manager/core/common/password_manager_ui.cc
+++ b/components/password_manager/core/common/password_manager_ui.cc
@@ -16,7 +16,8 @@ bool IsPendingState(State state) {
bool IsAutomaticDisplayState(State state) {
return state == PENDING_PASSWORD_AND_BUBBLE_STATE ||
- state == CONFIRMATION_STATE;
+ state == CONFIRMATION_STATE ||
+ state == CREDENTIAL_REQUEST_STATE;
}
State GetEndStateForAutomaticState(State state) {
@@ -24,10 +25,10 @@ State GetEndStateForAutomaticState(State state) {
switch (state) {
case PENDING_PASSWORD_AND_BUBBLE_STATE:
return PENDING_PASSWORD_STATE;
- break;
case CONFIRMATION_STATE:
return MANAGE_STATE;
- break;
+ case CREDENTIAL_REQUEST_STATE:
+ return CREDENTIAL_REQUEST_STATE;
Mike West 2014/11/21 11:21:12 We should talk about this, because it doesn't make
vasilii 2014/11/21 16:45:37 I introduced the second state.
default:
NOTREACHED();
return INACTIVE_STATE;

Powered by Google App Engine
This is Rietveld 408576698