Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.h

Issue 733463003: Show user credentials chooser bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with trunk Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_credential_manager_dispatcher.h
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.h b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
index 195cbe0d7f6c84713a202f08f599a37e467df44b..b508cef471041bbfd62bffae06d04d56f42048da 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.h
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_DISPATCHER_H_
#define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_DISPATCHER_H_
+#include "base/callback.h"
#include "base/macros.h"
#include "components/password_manager/core/browser/credential_manager_dispatcher.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
@@ -31,8 +32,6 @@ class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,
public content::WebContentsObserver,
public PasswordStoreConsumer {
public:
- // |client| isn't yet used by this class, but is necessary for the next step:
- // wiring this up as a subclass of PasswordStoreConsumer.
ContentCredentialManagerDispatcher(content::WebContents* web_contents,
PasswordManagerClient* client);
~ContentCredentialManagerDispatcher() override;
@@ -56,9 +55,14 @@ class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,
void OnGetPasswordStoreResults(
const std::vector<autofill::PasswordForm*>& results) override;
+ using CredentialCallback =
+ base::Callback<void(const autofill::PasswordForm&)>;
+
private:
PasswordStore* GetPasswordStore();
+ void SendCredential(int request_id, const CredentialInfo& info);
+
PasswordManagerClient* client_;
scoped_ptr<CredentialManagerPasswordFormManager> form_manager_;

Powered by Google App Engine
This is Rietveld 408576698