components/password_manager/core/browser/password_manager_client.h - Issue 733463003: Show user credentials chooser bubble.

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 733463003: Show user credentials chooser bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index 4bef91fb3fd4e2911b55e53ad4cb70f30e2b86b5..4673b22fde88075e3cfb8f4f595182e383777554 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -5,6 +5,7 @@

#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_

#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_

+#include "base/callback.h"

#include "base/metrics/field_trial.h"

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/password_store.h"

@@ -13,6 +14,7 @@ class PrefService;

namespace password_manager {

+struct CredentialInfo;

class PasswordFormManager;

class PasswordManagerDriver;

class PasswordStore;

@@ -63,6 +65,14 @@ class PasswordManagerClient {

virtual bool PromptUserToSavePassword(

scoped_ptr<PasswordFormManager> form_to_save) = 0;

+ // Informs the embedder of a password forms that the user should choose from.

+ // Returns true if the prompt is indeed displayed. In this case only

Mike West 2014/11/19 19:56:37 Nit: Might be clearer as "If the prompt is not dis

vasilii 2014/11/20 15:08:06 Done.

+ // |callback| should be invoked with the chosen form.

+ // Note: The implementation owns all PasswordForms in the vector.

Mike West 2014/11/19 19:56:37 Nit: s/owns/takes ownership of/

vasilii 2014/11/20 15:08:06 Done.

+ virtual bool PromptUserToChooseCredentials(

+ const std::vector<autofill::PasswordForm*>& forms,

+ base::Callback<void(const CredentialInfo&)> callback) = 0;

// Called when a password is saved in an automated fashion. Embedder may

// inform the user that this save has occured.