Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 733453002: Sync the documentation of seekable() with the MediaSource specification (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
Henrik Steen, fs
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Sync the documentation of seekable() with the MediaSource specification https://www.w3.org/Bugs/Public/show_bug.cgi?id=27296 Also tweak an assert to match the preceding comment. BUG=432051 R=henriks@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185799

Patch Set 1 #

Total comments: 2

Patch Set 2 : one more assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M LayoutTests/http/tests/media/media-source/mediasource-seekable.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
philipj_slow
PTAL. There was a misunderstanding with the assert_not_equals, this is what I had in mind.
6 years, 1 month ago (2014-11-14 12:57:37 UTC) #1
Henrik Steen
https://codereview.chromium.org/733453002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html File LayoutTests/http/tests/media/media-source/mediasource-seekable.html (right): https://codereview.chromium.org/733453002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html#newcode61 LayoutTests/http/tests/media/media-source/mediasource-seekable.html:61: assert_not_equals(mediaElement.seekable.end(0), mediaElement.buffered.start(0)); Hmm.. I would rather (or maybe "also") ...
6 years, 1 month ago (2014-11-21 07:46:12 UTC) #2
philipj_slow
one more assert
6 years, 1 month ago (2014-11-21 08:33:23 UTC) #3
philipj_slow
https://codereview.chromium.org/733453002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html File LayoutTests/http/tests/media/media-source/mediasource-seekable.html (right): https://codereview.chromium.org/733453002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html#newcode61 LayoutTests/http/tests/media/media-source/mediasource-seekable.html:61: assert_not_equals(mediaElement.seekable.end(0), mediaElement.buffered.start(0)); On 2014/11/21 07:46:12, Henrik Steen wrote: > ...
6 years, 1 month ago (2014-11-21 08:33:38 UTC) #4
Henrik Steen
lgtm
6 years, 1 month ago (2014-11-21 11:49:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733453002/20001
6 years, 1 month ago (2014-11-21 11:50:47 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-21 11:50:50 UTC) #9
philipj_slow
fs, please rubberstamp :)
6 years, 1 month ago (2014-11-21 14:48:50 UTC) #11
fs
lgtm
6 years, 1 month ago (2014-11-21 15:02:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733453002/20001
6 years, 1 month ago (2014-11-21 15:02:50 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 15:05:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185799

Powered by Google App Engine
This is Rietveld 408576698