Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 733443003: [DevTools] Used generated Inspector.detached in DevToolsHttpHandlerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index f2017cbb83454d6150e64cf33cbd159afd2c637c..1cd9222e24cc35c90f10f07ef6cc3eec549044cc 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -349,23 +349,16 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {
void AgentHostClosed(DevToolsAgentHost* agent_host,
bool replaced_with_another_client) override {
DCHECK(agent_host == agent_host_.get());
- agent_host_ = NULL;
-
- base::DictionaryValue notification;
- notification.SetString(
- devtools::Inspector::detached::kParamReason,
- replaced_with_another_client ?
- "replaced_with_devtools" : "target_closed");
- std::string response = DevToolsProtocol::CreateNotification(
- devtools::Inspector::detached::kName,
- notification.DeepCopy())->Serialize();
- message_loop_->PostTask(
- FROM_HERE,
- base::Bind(&ServerWrapper::SendOverWebSocket,
- base::Unretained(server_wrapper_),
- connection_id_,
- response));
+ base::Callback<void(const std::string&)> raw_message_callback(
+ base::Bind(&DevToolsAgentHostClientImpl::DispatchProtocolMessage,
+ base::Unretained(this), base::Unretained(agent_host)));
+ devtools::inspector::Client inspector(raw_message_callback);
+ inspector.Detached(devtools::inspector::DetachedParams::Create()
+ ->set_reason(replaced_with_another_client ?
+ "replaced_with_devtools" : "target_closed"));
+
+ agent_host_ = nullptr;
message_loop_->PostTask(
FROM_HERE,
base::Bind(&ServerWrapper::Close,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698