Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_unittest.py

Issue 733303003: [Telemetry] Introduce shared_user_story_state for real. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_set.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_unittest.py b/tools/telemetry/telemetry/user_story/user_story_unittest.py
index 6b926938e0e07a223c93a27a098303c6a4eeea2f..46ae6ff1bbb5257427cb5ba879ff779f4edc76c8 100644
--- a/tools/telemetry/telemetry/user_story/user_story_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_unittest.py
@@ -5,15 +5,24 @@
import unittest
from telemetry import user_story
+from telemetry.user_story import shared_user_story_state
-class UserStoryFoo(user_story.UserStory):
+
+# pylint: disable=abstract-method
+class SharedUserStoryStateBar(shared_user_story_state.SharedUserStoryState):
pass
+class UserStoryFoo(user_story.UserStory):
+ def __init__(self, name='', labels=None):
+ super(UserStoryFoo, self).__init__(
+ SharedUserStoryStateBar, name, labels)
+
+
class UserStoryTest(unittest.TestCase):
def testUserStoriesHaveDifferentIds(self):
- u0 = user_story.UserStory('foo')
- u1 = user_story.UserStory('bar')
+ u0 = user_story.UserStory(SharedUserStoryStateBar, 'foo')
+ u1 = user_story.UserStory(SharedUserStoryStateBar, 'bar')
self.assertNotEqual(u0.id, u1.id)
def testNamelessUserStoryDisplayName(self):
@@ -29,13 +38,13 @@ class UserStoryTest(unittest.TestCase):
self.assertEquals('Foo_Bar_Baz_0', u.file_safe_name)
def testNamelessUserStoryAsDict(self):
- u = user_story.UserStory()
+ u = user_story.UserStory(SharedUserStoryStateBar)
u_dict = u.AsDict()
self.assertEquals(u_dict['id'], u.id)
self.assertNotIn('name', u_dict)
def testNamedUserStoryAsDict(self):
- u = user_story.UserStory('Foo')
+ u = user_story.UserStory(SharedUserStoryStateBar, 'Foo')
u_dict = u.AsDict()
self.assertEquals(u_dict['id'], u.id)
self.assertEquals('Foo', u_dict['name'])
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_set.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698