Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 733283002: Move Element::attach recursion to the end. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move Element::attach recursion to the end. The animation style change logic only needs to be after the RenderTreeBuilder, not after attaching all descendants. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a51d9c67b6ac2b4760166e60e4c492476c9a13b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sky/engine/core/dom/Element.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
6 years, 1 month ago (2014-11-18 00:26:03 UTC) #2
esprehn
6 years, 1 month ago (2014-11-18 03:01:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a51d9c67b6ac2b4760166e60e4c492476c9a13b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698