Issue 733283002: Move Element::attach recursion to the end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 733283002: Move Element::attach recursion to the end. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Move Element::attach recursion to the end. The animation style change logic only needs to be after the RenderTreeBuilder, not after attaching all descendants. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a51d9c67b6ac2b4760166e60e4c492476c9a13b9

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	sky/engine/core/dom/Element.cpp	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years, 1 month ago (2014-11-18 03:01:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a51d9c67b6ac2b4760166e60e4c492476c9a13b9 (presubmit successful).