Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 733253005: Added few validations in Direct Write Font Cache code. (Closed)

Created:
6 years, 1 month ago by Shrikant Kelkar
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added few validations in Direct Write Font Cache code. - Added exclusive_write while writing to cache file, so that if there is any case where two utility processes try to write to cache at same time, it could be prevented. - Also added check to read minimum structure size bytes. BUG=434503 R=cpu,ananta Committed: https://crrev.com/bebcbc64bef44e63cbe88db487fb76ff383334f0 Cr-Commit-Position: refs/heads/master@{#305105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M content/common/dwrite_font_platform_win.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Shrikant Kelkar
6 years, 1 month ago (2014-11-18 23:51:44 UTC) #1
Shrikant Kelkar
ping
6 years, 1 month ago (2014-11-19 18:26:40 UTC) #2
ananta
lgtm
6 years, 1 month ago (2014-11-19 18:41:28 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-20 22:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733253005/1
6 years, 1 month ago (2014-11-20 22:25:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 23:08:21 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 23:11:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bebcbc64bef44e63cbe88db487fb76ff383334f0
Cr-Commit-Position: refs/heads/master@{#305105}

Powered by Google App Engine
This is Rietveld 408576698