src/runtime/runtime-object.cc - Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 3b302d160964044fb7e85e1d578e87db11e34496..de4e81248866601bad2a4f25dfdf237330c7a272 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -617,7 +617,7 @@ RUNTIME_FUNCTION(Runtime_KeyedGetProperty) {

NameDictionary* dictionary = receiver->property_dictionary();

int entry = dictionary->FindEntry(key);

if ((entry != NameDictionary::kNotFound) &&

- (dictionary->DetailsAt(entry).type() == NORMAL)) {

+ (dictionary->DetailsAt(entry).type() == FIELD)) {

Object* value = dictionary->ValueAt(entry);

if (!receiver->IsGlobalObject()) return value;

value = PropertyCell::cast(value)->value();

« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »