src/lookup.cc - Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 84eb6d45adc44cfacad6c94a77a93e1e80a22fa5..55e9d689a118765c97256aee5d5f98a8138d3ce2 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -102,7 +102,7 @@ void LookupIterator::ReconfigureDataProperty(Handle<Object> value,

DCHECK(HolderIsReceiverOrHiddenPrototype());

Handle<JSObject> holder = GetHolder<JSObject>();

if (holder_map_->is_dictionary_map()) {

- PropertyDetails details(attributes, NORMAL, 0);

+ PropertyDetails details(attributes, FIELD, 0);

JSObject::SetNormalizedProperty(holder, name(), value, details);

} else {

holder_map_ = Map::ReconfigureDataProperty(holder_map_, descriptor_number(),

« no previous file with comments | « src/lookup.h ('k') | src/lookup-inl.h » ('j') | no next file with comments »