src/ic/handler-compiler.cc - Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 7f440c07ca0e4de42d2000148a3cef236bfaa847..22135735f32fdca0639856c2d0a20563612d4da4 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -241,7 +241,8 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadInterceptor(

case LookupIterator::NOT_FOUND:

break;

case LookupIterator::DATA:

- inline_followup = it->property_details().type() == FIELD;

+ inline_followup =

+ it->property_details().type() == FIELD && !it->is_dictionary_holder();

break;

case LookupIterator::ACCESSOR: {

Handle<Object> accessors = it->GetAccessors();

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/lookup.h » ('j') | no next file with comments »