Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | src/x87/macro-assembler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 4349 matching lines...) Expand 10 before | Expand all | Expand 10 after
4360 times_pointer_size, 4360 times_pointer_size,
4361 SeededNumberDictionary::kElementsStartOffset)); 4361 SeededNumberDictionary::kElementsStartOffset));
4362 if (i != (kNumberDictionaryProbes - 1)) { 4362 if (i != (kNumberDictionaryProbes - 1)) {
4363 j(equal, &done); 4363 j(equal, &done);
4364 } else { 4364 } else {
4365 j(not_equal, miss); 4365 j(not_equal, miss);
4366 } 4366 }
4367 } 4367 }
4368 4368
4369 bind(&done); 4369 bind(&done);
4370 // Check that the value is a normal propety. 4370 // Check that the value is a field property.
4371 const int kDetailsOffset = 4371 const int kDetailsOffset =
4372 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize; 4372 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize;
4373 DCHECK_EQ(NORMAL, 0); 4373 DCHECK_EQ(FIELD, 0);
4374 Test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset), 4374 Test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset),
4375 Smi::FromInt(PropertyDetails::TypeField::kMask)); 4375 Smi::FromInt(PropertyDetails::TypeField::kMask));
4376 j(not_zero, miss); 4376 j(not_zero, miss);
4377 4377
4378 // Get the value at the masked, scaled index. 4378 // Get the value at the masked, scaled index.
4379 const int kValueOffset = 4379 const int kValueOffset =
4380 SeededNumberDictionary::kElementsStartOffset + kPointerSize; 4380 SeededNumberDictionary::kElementsStartOffset + kPointerSize;
4381 movp(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset)); 4381 movp(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset));
4382 } 4382 }
4383 4383
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
5394 if (mag.shift > 0) sarl(rdx, Immediate(mag.shift)); 5394 if (mag.shift > 0) sarl(rdx, Immediate(mag.shift));
5395 movl(rax, dividend); 5395 movl(rax, dividend);
5396 shrl(rax, Immediate(31)); 5396 shrl(rax, Immediate(31));
5397 addl(rdx, rax); 5397 addl(rdx, rax);
5398 } 5398 }
5399 5399
5400 5400
5401 } } // namespace v8::internal 5401 } } // namespace v8::internal
5402 5402
5403 #endif // V8_TARGET_ARCH_X64 5403 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | src/x87/macro-assembler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698