Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup-inl.h ('k') | src/mips64/macro-assembler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS 9 #if V8_TARGET_ARCH_MIPS
10 10
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 584
585 lw(at, FieldMemOperand(reg2, SeededNumberDictionary::kElementsStartOffset)); 585 lw(at, FieldMemOperand(reg2, SeededNumberDictionary::kElementsStartOffset));
586 if (i != kNumberDictionaryProbes - 1) { 586 if (i != kNumberDictionaryProbes - 1) {
587 Branch(&done, eq, key, Operand(at)); 587 Branch(&done, eq, key, Operand(at));
588 } else { 588 } else {
589 Branch(miss, ne, key, Operand(at)); 589 Branch(miss, ne, key, Operand(at));
590 } 590 }
591 } 591 }
592 592
593 bind(&done); 593 bind(&done);
594 // Check that the value is a normal property. 594 // Check that the value is a field property.
595 // reg2: elements + (index * kPointerSize). 595 // reg2: elements + (index * kPointerSize).
596 const int kDetailsOffset = 596 const int kDetailsOffset =
597 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize; 597 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize;
598 lw(reg1, FieldMemOperand(reg2, kDetailsOffset)); 598 lw(reg1, FieldMemOperand(reg2, kDetailsOffset));
599 DCHECK_EQ(FIELD, 0);
599 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask))); 600 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask)));
600 Branch(miss, ne, at, Operand(zero_reg)); 601 Branch(miss, ne, at, Operand(zero_reg));
601 602
602 // Get the value at the masked, scaled index and return. 603 // Get the value at the masked, scaled index and return.
603 const int kValueOffset = 604 const int kValueOffset =
604 SeededNumberDictionary::kElementsStartOffset + kPointerSize; 605 SeededNumberDictionary::kElementsStartOffset + kPointerSize;
605 lw(result, FieldMemOperand(reg2, kValueOffset)); 606 lw(result, FieldMemOperand(reg2, kValueOffset));
606 } 607 }
607 608
608 609
(...skipping 5653 matching lines...) Expand 10 before | Expand all | Expand 10 after
6262 } 6263 }
6263 if (mag.shift > 0) sra(result, result, mag.shift); 6264 if (mag.shift > 0) sra(result, result, mag.shift);
6264 srl(at, dividend, 31); 6265 srl(at, dividend, 31);
6265 Addu(result, result, Operand(at)); 6266 Addu(result, result, Operand(at));
6266 } 6267 }
6267 6268
6268 6269
6269 } } // namespace v8::internal 6270 } } // namespace v8::internal
6270 6271
6271 #endif // V8_TARGET_ARCH_MIPS 6272 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/lookup-inl.h ('k') | src/mips64/macro-assembler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698