Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/bootstrapper.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/extensions/externalize-string-extension.h" 9 #include "src/extensions/externalize-string-extension.h"
10 #include "src/extensions/free-buffer-extension.h" 10 #include "src/extensions/free-buffer-extension.h"
(...skipping 2581 matching lines...) Expand 10 before | Expand all | Expand 10 after
2592 if (it.IsFound()) continue; 2592 if (it.IsFound()) continue;
2593 HandleScope inner(isolate()); 2593 HandleScope inner(isolate());
2594 DCHECK(!to->HasFastProperties()); 2594 DCHECK(!to->HasFastProperties());
2595 // Add to dictionary. 2595 // Add to dictionary.
2596 Handle<Object> callbacks(descs->GetCallbacksObject(i), isolate()); 2596 Handle<Object> callbacks(descs->GetCallbacksObject(i), isolate());
2597 PropertyDetails d = PropertyDetails( 2597 PropertyDetails d = PropertyDetails(
2598 details.attributes(), CALLBACKS, i + 1); 2598 details.attributes(), CALLBACKS, i + 1);
2599 JSObject::SetNormalizedProperty(to, key, callbacks, d); 2599 JSObject::SetNormalizedProperty(to, key, callbacks, d);
2600 break; 2600 break;
2601 } 2601 }
2602 // Do not occur since the from object has fast properties.
2603 case NORMAL:
2604 UNREACHABLE();
2605 break;
2606 } 2602 }
2607 } 2603 }
2608 } else { 2604 } else {
2609 Handle<NameDictionary> properties = 2605 Handle<NameDictionary> properties =
2610 Handle<NameDictionary>(from->property_dictionary()); 2606 Handle<NameDictionary>(from->property_dictionary());
2611 int capacity = properties->Capacity(); 2607 int capacity = properties->Capacity();
2612 for (int i = 0; i < capacity; i++) { 2608 for (int i = 0; i < capacity; i++) {
2613 Object* raw_key(properties->KeyAt(i)); 2609 Object* raw_key(properties->KeyAt(i));
2614 if (properties->IsKey(raw_key)) { 2610 if (properties->IsKey(raw_key)) {
2615 DCHECK(raw_key->IsName()); 2611 DCHECK(raw_key->IsName());
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
2835 return from + sizeof(NestingCounterType); 2831 return from + sizeof(NestingCounterType);
2836 } 2832 }
2837 2833
2838 2834
2839 // Called when the top-level V8 mutex is destroyed. 2835 // Called when the top-level V8 mutex is destroyed.
2840 void Bootstrapper::FreeThreadResources() { 2836 void Bootstrapper::FreeThreadResources() {
2841 DCHECK(!IsActive()); 2837 DCHECK(!IsActive());
2842 } 2838 }
2843 2839
2844 } } // namespace v8::internal 2840 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698