Revert of cc: Toggle LCD text at raster time instead of record time.

cc/trees/layer_tree_host_common_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_common.h"
 
 #include <algorithm>
 #include <set>
 
 #include "cc/animation/layer_animation_controller.h"
@@ skipping 41 matching lines @@
 bool LayerWithForcedDrawsContent::DrawsContent() const { return true; }
 
 class MockContentLayerClient : public ContentLayerClient {
  public:
   MockContentLayerClient() {}
   ~MockContentLayerClient() override {}
   void PaintContents(
       SkCanvas* canvas,
       const gfx::Rect& clip,
       ContentLayerClient::GraphicsContextStatus gc_status) override {}
+  void DidChangeLayerCanUseLCDText() override {}
   bool FillsBoundsCompletely() const override { return false; }
 };
 
 scoped_refptr<FakePictureLayer> CreateDrawablePictureLayer(
     ContentLayerClient* delegate) {
   scoped_refptr<FakePictureLayer> to_return =
       FakePictureLayer::Create(delegate);
   to_return->SetIsDrawable(true);
   return to_return;
 }
@@ skipping 5564 matching lines @@
       root.get(), root->bounds(), &render_surface_layer_list);
   inputs.can_adjust_raster_scales = true;
   LayerTreeHostCommon::CalculateDrawProperties(&inputs);
 
   // We should have one render surface and two layers. The child
   // layer should be included even though it is transparent.
   ASSERT_EQ(1u, render_surface_layer_list.size());
   ASSERT_EQ(2u, root->render_surface()->layer_list().size());
 }
 
-using LCDTextTestParam = std::tr1::tuple<bool, bool, bool>;
+typedef std::tr1::tuple<bool, bool> LCDTextTestParam;
 class LCDTextTest
     : public LayerTreeHostCommonTestBase,
       public testing::TestWithParam<LCDTextTestParam> {
  protected:
   virtual void SetUp() {
     can_use_lcd_text_ = std::tr1::get<0>(GetParam());
-    layers_always_allowed_lcd_text_ = std::tr1::get<1>(GetParam());
 
     root_ = Layer::Create();
     child_ = Layer::Create();
     grand_child_ = Layer::Create();
     child_->AddChild(grand_child_.get());
     root_->AddChild(child_.get());
 
     gfx::Transform identity_matrix;
     SetLayerPropertiesForTesting(root_.get(),
                                  identity_matrix,
@@ skipping 10 matching lines @@
                                  true,
                                  false);
     SetLayerPropertiesForTesting(grand_child_.get(),
                                  identity_matrix,
                                  gfx::Point3F(),
                                  gfx::PointF(),
                                  gfx::Size(1, 1),
                                  true,
                                  false);
 
-    child_->SetForceRenderSurface(std::tr1::get<2>(GetParam()));
+    child_->SetForceRenderSurface(std::tr1::get<1>(GetParam()));
 
     host_ = CreateFakeLayerTreeHost();
     host_->SetRootLayer(root_);
   }
 
   bool can_use_lcd_text_;
-  bool layers_always_allowed_lcd_text_;
   scoped_ptr<FakeLayerTreeHost> host_;
   scoped_refptr<Layer> root_;
   scoped_refptr<Layer> child_;
   scoped_refptr<Layer> grand_child_;
 };
 
 TEST_P(LCDTextTest, CanUseLCDText) {
-  bool expect_lcd_text = can_use_lcd_text_ || layers_always_allowed_lcd_text_;
-  bool expect_not_lcd_text = layers_always_allowed_lcd_text_;
-
   // Case 1: Identity transform.
   gfx::Transform identity_matrix;
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
 
   // Case 2: Integral translation.
   gfx::Transform integral_translation;
   integral_translation.Translate(1.0, 2.0);
   child_->SetTransform(integral_translation);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
 
   // Case 3: Non-integral translation.
   gfx::Transform non_integral_translation;
   non_integral_translation.Translate(1.5, 2.5);
   child_->SetTransform(non_integral_translation);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_FALSE(child_->can_use_lcd_text());
+  EXPECT_FALSE(grand_child_->can_use_lcd_text());
 
   // Case 4: Rotation.
   gfx::Transform rotation;
   rotation.Rotate(10.0);
   child_->SetTransform(rotation);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_FALSE(child_->can_use_lcd_text());
+  EXPECT_FALSE(grand_child_->can_use_lcd_text());
 
   // Case 5: Scale.
   gfx::Transform scale;
   scale.Scale(2.0, 2.0);
   child_->SetTransform(scale);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_FALSE(child_->can_use_lcd_text());
+  EXPECT_FALSE(grand_child_->can_use_lcd_text());
 
   // Case 6: Skew.
   gfx::Transform skew;
   skew.SkewX(10.0);
   child_->SetTransform(skew);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_FALSE(child_->can_use_lcd_text());
+  EXPECT_FALSE(grand_child_->can_use_lcd_text());
 
   // Case 7: Translucent.
   child_->SetTransform(identity_matrix);
   child_->SetOpacity(0.5f);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_not_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_FALSE(child_->can_use_lcd_text());
+  EXPECT_FALSE(grand_child_->can_use_lcd_text());
 
   // Case 8: Sanity check: restore transform and opacity.
   child_->SetTransform(identity_matrix);
   child_->SetOpacity(1.f);
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
 }
 
 TEST_P(LCDTextTest, CanUseLCDTextWithAnimation) {
-  bool expect_lcd_text = can_use_lcd_text_ || layers_always_allowed_lcd_text_;
-
   // Sanity check: Make sure can_use_lcd_text_ is set on each node.
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, grand_child_->can_use_lcd_text());
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
 
   // Add opacity animation.
   child_->SetOpacity(0.9f);
   AddOpacityTransitionToController(
       child_->layer_animation_controller(), 10.0, 0.9f, 0.1f, false);
 
-  ExecuteCalculateDrawProperties(root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_,
-                                 layers_always_allowed_lcd_text_);
+  ExecuteCalculateDrawProperties(
+      root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
   // Text AA should not be adjusted while animation is active.
   // Make sure LCD text AA setting remains unchanged.
-  EXPECT_EQ(expect_lcd_text, root_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, child_->can_use_lcd_text());
-  EXPECT_EQ(expect_lcd_text, grand_child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
+  EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
 }
 
 INSTANTIATE_TEST_CASE_P(LayerTreeHostCommonTest,
                         LCDTextTest,
-                        testing::Combine(testing::Bool(),
-                                         testing::Bool(),
-                                         testing::Bool()));
+                        testing::Combine(testing::Bool(), testing::Bool()));
 
 TEST_F(LayerTreeHostCommonTest, SubtreeHidden_SingleLayer) {
   FakeImplProxy proxy;
   TestSharedBitmapManager shared_bitmap_manager;
   FakeLayerTreeHostImpl host_impl(&proxy, &shared_bitmap_manager);
   host_impl.CreatePendingTree();
   const gfx::Transform identity_matrix;
 
   scoped_refptr<Layer> root = Layer::Create();
   SetLayerPropertiesForTesting(root.get(),
@@ skipping 2777 matching lines @@
   // by the viewport.
   EXPECT_EQ(gfx::Rect(768 / 2, 582 / 2), root->visible_content_rect());
 
   // Layers drawing to a child render surface should still have their visible
   // content rect clipped by the viewport.
   EXPECT_EQ(gfx::Rect(768 / 2, 582 / 2), content->visible_content_rect());
 }
 
 }  // namespace
 }  // namespace cc