Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 733163003: Switch SkBitmapProcState's SkFractionalInt to 32.32. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Switch SkBitmapProcState's SkFractionalInt to 32.32. 16 bits are not enough to hold the integral part of fx in Clamp_S32_opaque_D32_nofilter_DX_shaderproc. Weirdly, no GM diffs on my desktop. BUG=skia:3096 Committed: https://skia.googlesource.com/skia/+/179465150939c2f2420bfc15dc33825b1130e7f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M include/core/SkFixed.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +5 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years, 1 month ago (2014-11-17 16:50:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733163003/1
6 years, 1 month ago (2014-11-17 16:51:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-17 16:51:00 UTC) #5
commit-bot: I haz the power
Presubmit check for 733163003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-11-17 16:51:04 UTC) #7
reed1
I see 5% slowdown on nanobench --match bitmap_RGBA_8888_scale on 32bit android. No slowdown at all ...
6 years, 1 month ago (2014-11-21 19:57:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733163003/1
6 years, 1 month ago (2014-11-21 19:59:31 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 20:10:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/179465150939c2f2420bfc15dc33825b1130e7f7

Powered by Google App Engine
This is Rietveld 408576698