Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 733053005: cc: Add UMA stats for texture copy latency. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add UMA stats for texture copy latency. Records the time between the issue of a texture copy operation and detecting that it has completed as measured by the GPU process. This data is useful to determine potential driver problems related to fences. Consistent high latency (200ms and above) for copy operations is a strong indication of a misbehaving fence extension. The data can also be used to determine the amount of staging resources to use for optimal performance. BUG=431845 Committed: https://crrev.com/63294bc251336f3e59240642676a5e758a8c2192 Cr-Commit-Position: refs/heads/master@{#304562}

Patch Set 1 #

Patch Set 2 : fix unit test #

Patch Set 3 : fix one more unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M cc/resources/resource_provider.cc View 4 chunks +22 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_query_unittest.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
reveman
6 years, 1 month ago (2014-11-17 14:57:48 UTC) #2
no sievers
lgtm
6 years, 1 month ago (2014-11-17 20:03:23 UTC) #3
reveman
+piman for cc/ +asvitkine for tools/metrics/histograms/
6 years, 1 month ago (2014-11-17 20:46:44 UTC) #5
piman
lgtm
6 years, 1 month ago (2014-11-17 20:50:17 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-11-17 22:38:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733053005/1
6 years, 1 month ago (2014-11-18 00:49:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/80976) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/12702)
6 years, 1 month ago (2014-11-18 01:33:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733053005/20001
6 years, 1 month ago (2014-11-18 02:08:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/10995) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/6582)
6 years, 1 month ago (2014-11-18 02:57:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733053005/40001
6 years, 1 month ago (2014-11-18 03:07:32 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-18 05:06:34 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 05:07:23 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/63294bc251336f3e59240642676a5e758a8c2192
Cr-Commit-Position: refs/heads/master@{#304562}

Powered by Google App Engine
This is Rietveld 408576698