Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 733053004: cps-ir: Add a test for codegeneration. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 2eaad68c6cbf6998afc6dbbe0425909ba64ff31f..9de01de2814127c798034820350ae4f1d5fbce38 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1813,26 +1813,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
}
- void generateConstant(ConstantValue constant) {
- if (constant.isFunction) {
- FunctionConstantValue function = constant;
- registry.registerStaticUse(function.element);
- }
- if (constant.isType) {
- // If the type is a web component, we need to ensure the constructors are
- // available to 'upgrade' the native object.
- TypeConstantValue type = constant;
- Element element = type.representedType.element;
- if (element != null && element.isClass) {
- registry.registerTypeConstant(element);
- }
- }
- push(backend.emitter.constantReference(constant));
- }
-
visitConstant(HConstant node) {
assert(isGenerateAtUseSite(node));
- generateConstant(node.constant);
+ push(backend.emitter.constantReference(node.constant));
floitsch 2014/11/17 15:03:30 Please keep the code. I tried to remove it in a se
karlklose 2014/11/17 16:11:58 That was a merge error, reverted.
registry.registerCompileTimeConstant(node.constant);
backend.constants.addCompileTimeConstantForEmission(node.constant);

Powered by Google App Engine
This is Rietveld 408576698