Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 733023003: Reland "Soft fail for invalid cache data." (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
vogelheim1, vogelheim
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland "Soft fail for invalid cache data." Committed: https://chromium.googlesource.com/v8/v8/+/93ea6fe729de05290c161432429fedbe38511e37

Patch Set 1 #

Patch Set 2 : fix leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -45 lines) Patch
M include/v8.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 3 chunks +16 lines, -3 lines 0 comments Download
M src/parser.cc View 8 chunks +10 lines, -13 lines 0 comments Download
M src/serialize.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/serialize.cc View 1 5 chunks +15 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
Please take a look. Second patch set is the fix.
6 years, 1 month ago (2014-11-17 08:14:08 UTC) #2
vogelheim1
lgtm Thanks for making the fix a separate patch set. Makes review super easy... :)
6 years, 1 month ago (2014-11-17 11:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733023003/20001
6 years, 1 month ago (2014-11-17 11:49:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 12:16:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698