Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 732983005: Prefix CommandLine usege with base namespace (Part 5: cc/) (Closed)

Created:
6 years, 1 month ago by elecro
Modified:
6 years, 1 month ago
Reviewers:
danakj, nduca, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usege with base namespace (Part 5: cc/) Prefix all CommandLine usage in the cc/ directory with the base:: namespace. BUG=422426 Committed: https://crrev.com/8c86796369cab3bfadd8b4e2c69863101cd524ea Cr-Commit-Position: refs/heads/master@{#304616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
elecro
Please take a look.
6 years, 1 month ago (2014-11-18 14:24:34 UTC) #2
danakj
LGTM
6 years, 1 month ago (2014-11-18 15:42:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732983005/1
6 years, 1 month ago (2014-11-18 15:43:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 16:24:52 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 16:25:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c86796369cab3bfadd8b4e2c69863101cd524ea
Cr-Commit-Position: refs/heads/master@{#304616}

Powered by Google App Engine
This is Rietveld 408576698