Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4880)

Unified Diff: chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

Issue 732943002: New Getting started example for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments #21 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html
diff --git a/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html
index f58540d5d551b4af8b13f63ad2c82b680ff36181..c88cc9c0237e7d618f25cc00bcb7a6be8c069636 100644
--- a/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html
+++ b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html
@@ -1,19 +1,23 @@
<!doctype html>
+<!--
+ This page is shown when the extension button is clicked, because the
+ "browser_action" field in manifest.json contains the "default_popup" key with
+ value "popup.html".
+ -->
<html>
<head>
<title>Getting Started Extension's Popup</title>
<style>
body {
- min-width: 357px;
- overflow-x: hidden;
+ font-family: "Segoe UI", "Lucida Grande", Tahoma, sans-serif;
+ font-size: 100%;
}
-
- img {
- margin: 5px;
- border: 2px solid black;
- vertical-align: middle;
- width: 75px;
- height: 75px;
+ #status {
+ /* avoid an excessively wide status text */
+ white-space: pre;
+ text-overflow: ellipsis;
+ overflow: hidden;
+ max-width: 400px;
}
</style>
@@ -21,11 +25,13 @@
- JavaScript and HTML must be in separate files: see our Content Security
- Policy documentation[1] for details and explanation.
-
- - [1]: http://developer.chrome.com/extensions/contentSecurityPolicy.html
+ - [1]: https://developer.chrome.com/extensions/contentSecurityPolicy
-->
<script src="popup.js"></script>
</head>
<body>
+ <div id="status"></div>
+ <img id="image-result" hidden>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698