chromecast/browser/devtools/remote_debugging_server.cc - Issue 732833002: Chromecast buildfix: scoped_ptr cannot be initialized with NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/remote_debugging_server.cc

Issue 732833002: Chromecast buildfix: scoped_ptr cannot be initialized with NULL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/devtools/remote_debugging_server.cc

diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc

index 9b2bfc5097730a2ff70c4a77dd927f9597c6f023..fcbe5e0e7cc730df149f2999e947c1c6c7500283 100644

--- a/chromecast/browser/devtools/remote_debugging_server.cc

+++ b/chromecast/browser/devtools/remote_debugging_server.cc

@@ -94,7 +94,7 @@ std::string GetFrontendUrl() {

} // namespace

RemoteDebuggingServer::RemoteDebuggingServer()

- : devtools_http_handler_(NULL),

+ : devtools_http_handler_(),

lcwu1 2014/11/14 23:26:59 Why don't you simply remove this member from the i

gunsch 2014/11/14 23:36:44 Done.

port_(0) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

pref_port_.Init(prefs::kRemoteDebuggingPort,

« no previous file with comments | « no previous file | no next file » | no next file with comments »