Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 732833002: Chromecast buildfix: scoped_ptr cannot be initialized with NULL. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
lcwu1
CC:
chromium-reviews, vsevik, lcwu+watch_chromium.org, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, gunsch+watch_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast buildfix: scoped_ptr cannot be initialized with NULL. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/cef99a943f303c78969acef43d637e29afc9b222 Cr-Commit-Position: refs/heads/master@{#304314}

Patch Set 1 #

Total comments: 2

Patch Set 2 : lcwu comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chromecast/browser/devtools/remote_debugging_server.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years, 1 month ago (2014-11-14 22:38:38 UTC) #1
lcwu1
https://codereview.chromium.org/732833002/diff/1/chromecast/browser/devtools/remote_debugging_server.cc File chromecast/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/732833002/diff/1/chromecast/browser/devtools/remote_debugging_server.cc#newcode97 chromecast/browser/devtools/remote_debugging_server.cc:97: : devtools_http_handler_(), Why don't you simply remove this member ...
6 years, 1 month ago (2014-11-14 23:27:00 UTC) #2
gunsch
https://codereview.chromium.org/732833002/diff/1/chromecast/browser/devtools/remote_debugging_server.cc File chromecast/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/732833002/diff/1/chromecast/browser/devtools/remote_debugging_server.cc#newcode97 chromecast/browser/devtools/remote_debugging_server.cc:97: : devtools_http_handler_(), On 2014/11/14 23:26:59, lcwu1 wrote: > Why ...
6 years, 1 month ago (2014-11-14 23:36:44 UTC) #3
lcwu1
lgtm
6 years, 1 month ago (2014-11-14 23:37:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732833002/20001
6 years, 1 month ago (2014-11-14 23:39:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-15 00:29:07 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 00:47:21 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cef99a943f303c78969acef43d637e29afc9b222
Cr-Commit-Position: refs/heads/master@{#304314}

Powered by Google App Engine
This is Rietveld 408576698