Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 732803003: Clean up forward declarations in Source/core (Closed)

Created:
6 years, 1 month ago by zhaoze.zhou
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, shans, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dcheng, yurys+blink_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, falken, caseq+blink_chromium.org, Steve Block, pfeldman+blink_chromium.org, malch+blink_chromium.org, blink-reviews-html_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, Eric Willigers, rjwright, zoltan1, blink-reviews-paint_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, Nate Chapin, tyoshino+watch_chromium.org, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), horo+watch_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core These forward references are not needed anymore. After this patch, Source/core has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M Source/core/animation/ActiveAnimations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/DocumentAnimations.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/clipboard/DataTransferItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/QualifiedName.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleChangeReason.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/StyleElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementDescriptor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/FontResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/paint/FilterPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMPlugin.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/PluginView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/storage/StorageArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/storage/StorageNamespace.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/streams/UnderlyingSource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/LayerRectList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/v8/WebCoreTestSupport.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XSLImportRule.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
zhaoze.zhou
6 years, 1 month ago (2014-11-14 22:12:49 UTC) #2
rwlbuis
lgtm Good to see that we now tackle bigger chunks. LGTM if all compiles.
6 years, 1 month ago (2014-11-14 23:07:51 UTC) #3
rwlbuis
lgtm Good to see that we now tackle bigger chunks. LGTM if all compiles.
6 years, 1 month ago (2014-11-14 23:07:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732803003/1
6 years, 1 month ago (2014-11-14 23:25:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30994)
6 years, 1 month ago (2014-11-15 00:57:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732803003/1
6 years, 1 month ago (2014-11-15 01:08:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/31012)
6 years, 1 month ago (2014-11-15 01:59:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732803003/1
6 years, 1 month ago (2014-11-15 03:49:39 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 04:28:30 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185404

Powered by Google App Engine
This is Rietveld 408576698