DescriptionReland HTMLPlugInElement: Use custom focus logic only when there is a plugin.
This is a reland of https://codereview.chromium.org/717193003/
which was reverted due to a SyzyASAN failure:
https://code.google.com/p/chromium/issues/detail?id=433357
I'm not quite sure how my patch caused the issue, but reverting it did fix it.
It seems that layout was being triggered during isKeyboardFocusable(), during
which the plugin element itself was destroyed.
This changes that path to only use an existing plugin to check for keyboard
focusability, similar to other code in HTMLPlugInElement.
TEST=fast/plugins/plugin/placeholder-focus.html
BUG=364716
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185468
Patch Set 1 #Patch Set 2 : form value access immediate (plugins/form-value.html) #Patch Set 3 : rebase #
Messages
Total messages: 9 (3 generated)
|