Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 732763002: Add a basic img test. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A sky/tests/lowlevel/img.sky View 1 chunk +7 lines, -0 lines 0 comments Download
A sky/tests/lowlevel/img-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A + sky/tests/lowlevel/resources/palatted-color-png-gamma-one-color-profile.png View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
There's a lot more useful testing we should do around replaced elements, but this basic ...
6 years, 1 month ago (2014-11-14 19:47:50 UTC) #1
ojan
btw, i grabbed the png out of the tests/fast directory.
6 years, 1 month ago (2014-11-14 19:48:14 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-14 20:06:40 UTC) #4
ojan
6 years, 1 month ago (2014-11-14 21:58:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f86f9737f46170a0c5cd6a753c8a2034e08534d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698