Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 7327036: Merge svn r8602 to the 3.3 branch. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge svn r8602 to the 3.3 branch. r8602: Fix a potential crash in const declaration. Declaration of const lookup slots would trigger an assertion if there was a setter somewhere in the prototype chain, and that setter was shadowed by a non-readonly data property also in the prototype chain. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8608

Patch Set 1 #

Patch Set 2 : Updated version.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/objects.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 5 months ago (2011-07-11 14:41:30 UTC) #1
Mads Ager (chromium)
9 years, 5 months ago (2011-07-11 14:58:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698