Issue 7327019: Fix the build by updating some paths in Python.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7327019: Fix the build by updating some paths in Python. (Closed)

Created:
9 years, 5 months ago by brettw

Modified:
9 years, 5 months ago

Reviewers:
noelallen1

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

Fix the build by updating some paths in Python. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5948

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/coverage_helper.py	View	1	2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

noelallen1

9 years, 5 months ago (2011-07-08 16:18:20 UTC) #2

LGTM, but we need a way to track all these little changes so we don't go through
this again removing it.

http://codereview.chromium.org/7327019/diff/2001/tools/coverage_helper.py
File tools/coverage_helper.py (right):

http://codereview.chromium.org/7327019/diff/2001/tools/coverage_helper.py#new...
tools/coverage_helper.py:37: filters = ['src/third_party/ppapi/c',
'src/third_party/ppapi/cpp',
We'll need to remember to undo this...
Could you add a comment or file a bug so we can remember what we need to unwind
when we take ppapi back out of NaCl?

Expand Messages | Collapse Messages