chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/accessibility_win_browsertest.cc ('K') | « chrome/browser/ui/cocoa/info_bubble_window.mm ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h » ('j') | content/common/notification_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm

===================================================================

--- chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (revision 91880)

+++ chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (working copy)

@@ -25,18 +25,18 @@

private:

// NotificationObserver implementation

- void Observe(NotificationType type,

+ void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

TabContentsWrapper* tab_contents = Source<TabContentsWrapper>(source).ptr();

- switch (type.value) {

- case NotificationType::TAB_CONTENTS_INFOBAR_ADDED:

+ switch (type) {

+ case chrome::TAB_CONTENTS_INFOBAR_ADDED:

[controller_ addInfoBar:Details<InfoBarAddedDetails>(details)->

CreateInfoBar(tab_contents)

animate:YES];

break;

- case NotificationType::TAB_CONTENTS_INFOBAR_REMOVED: {

+ case chrome::TAB_CONTENTS_INFOBAR_REMOVED: {

InfoBarRemovedDetails* removed_details =

Details<InfoBarRemovedDetails>(details).ptr();

[controller_

@@ -45,7 +45,7 @@

break;

}

- case NotificationType::TAB_CONTENTS_INFOBAR_REPLACED: {

+ case chrome::TAB_CONTENTS_INFOBAR_REPLACED: {

InfoBarReplacedDetails* replaced_details =

Details<InfoBarReplacedDetails>(details).ptr();

[controller_ closeInfoBarsForDelegate:replaced_details->first

@@ -138,11 +138,11 @@

Source<TabContentsWrapper> source(currentTabContents_);

registrar_.Add(infoBarObserver_.get(),

- NotificationType::TAB_CONTENTS_INFOBAR_ADDED, source);

+ chrome::TAB_CONTENTS_INFOBAR_ADDED, source);

registrar_.Add(infoBarObserver_.get(),

- NotificationType::TAB_CONTENTS_INFOBAR_REMOVED, source);

+ chrome::TAB_CONTENTS_INFOBAR_REMOVED, source);

registrar_.Add(infoBarObserver_.get(),

- NotificationType::TAB_CONTENTS_INFOBAR_REPLACED, source);

+ chrome::TAB_CONTENTS_INFOBAR_REPLACED, source);

}

[self positionInfoBarsAndRedraw];