chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/accessibility_win_browsertest.cc ('K') | « chrome/browser/ui/cocoa/location_bar/page_action_decoration.h ('k') | chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm » ('j') | content/common/notification_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

===================================================================

--- chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm (revision 91880)

+++ chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm (working copy)

@@ -58,7 +58,7 @@

ImageLoadingTracker::DONT_CACHE);

}

- registrar_.Add(this, NotificationType::EXTENSION_HOST_VIEW_SHOULD_CLOSE,

+ registrar_.Add(this, chrome::EXTENSION_HOST_VIEW_SHOULD_CLOSE,

Source<Profile>(profile_));

// We set the owner last of all so that we can determine whether we are in

@@ -185,7 +185,7 @@

if (IsVisible() != visible) {

SetVisible(visible);

NotificationService::current()->Notify(

- NotificationType::EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,

+ chrome::EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,

Source<ExtensionAction>(page_action_),

Details<TabContents>(contents));

}

@@ -239,11 +239,11 @@

}

void PageActionDecoration::Observe(

- NotificationType type,

+ int type,

const NotificationSource& source,

const NotificationDetails& details) {

- switch (type.value) {

- case NotificationType::EXTENSION_HOST_VIEW_SHOULD_CLOSE: {

+ switch (type) {

+ case chrome::EXTENSION_HOST_VIEW_SHOULD_CLOSE: {

ExtensionPopupController* popup = [ExtensionPopupController popup];

if (popup && ![popup isClosing])

[popup close];