chrome/browser/chromeos/media/media_player.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/media/media_player.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/accessibility_win_browsertest.cc ('K') | « chrome/browser/chromeos/media/media_player.h ('k') | chrome/browser/chromeos/network_state_notifier.cc » ('j') | content/common/notification_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/media/media_player.cc

===================================================================

--- chrome/browser/chromeos/media/media_player.cc (revision 91880)

+++ chrome/browser/chromeos/media/media_player.cc (working copy)

@@ -162,12 +162,12 @@

NotifyPlaylistChanged();

}

-void MediaPlayer::Observe(NotificationType type,

+void MediaPlayer::Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

- DCHECK(type == NotificationType::BROWSER_CLOSING);

+ DCHECK(type == chrome::NOTIFICATION_BROWSER_CLOSING);

registrar_.Remove(this,

- NotificationType::BROWSER_CLOSING,

+ chrome::NOTIFICATION_BROWSER_CLOSING,

source);

if (Source<Browser>(source).ptr() == mediaplayer_browser_) {

mediaplayer_browser_ = NULL;

@@ -203,7 +203,7 @@

gfx::Rect(),

profile);

registrar_.Add(this,

- NotificationType::BROWSER_CLOSING,

+ chrome::NOTIFICATION_BROWSER_CLOSING,

Source<Browser>(playlist_browser_));

playlist_browser_->AddSelectedTabWithURL(GetMediaplayerPlaylistUrl(),

PageTransition::LINK);

@@ -228,7 +228,7 @@

gfx::Rect(),

profile);

registrar_.Add(this,

- NotificationType::BROWSER_CLOSING,

+ chrome::NOTIFICATION_BROWSER_CLOSING,

Source<Browser>(mediaplayer_browser_));

#if defined(OS_CHROMEOS)