chrome/browser/chromeos/login/login_html_dialog.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_html_dialog.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/accessibility_win_browsertest.cc ('K') | « chrome/browser/chromeos/login/login_html_dialog.h ('k') | chrome/browser/chromeos/login/login_performer.h » ('j') | content/common/notification_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/login_html_dialog.cc

===================================================================

--- chrome/browser/chromeos/login/login_html_dialog.cc (revision 91880)

+++ chrome/browser/chromeos/login/login_html_dialog.cc (working copy)

@@ -65,7 +65,7 @@

if (bubble_frame_view_) {

bubble_frame_view_->StartThrobber();

notification_registrar_.Add(this,

- NotificationType::LOAD_COMPLETED_MAIN_FRAME,

+ chrome::LOAD_COMPLETED_MAIN_FRAME,

NotificationService::AllSources());

}

html_view->InitDialog();

@@ -128,10 +128,10 @@

return true;

}

-void LoginHtmlDialog::Observe(NotificationType type,

+void LoginHtmlDialog::Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

- DCHECK(type.value == NotificationType::LOAD_COMPLETED_MAIN_FRAME);

+ DCHECK(type == chrome::LOAD_COMPLETED_MAIN_FRAME);

if (bubble_frame_view_)

bubble_frame_view_->StopThrobber();

}