Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/gtk/global_menu_bar.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/global_menu_bar.h" 5 #include "chrome/browser/ui/gtk/global_menu_bar.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 dummy_accel_group_, 206 dummy_accel_group_,
207 accelerator_gtk->GetGdkKeyCode(), 207 accelerator_gtk->GetGdkKeyCode(),
208 accelerator_gtk->gdk_modifier_type(), 208 accelerator_gtk->gdk_modifier_type(),
209 GTK_ACCEL_VISIBLE); 209 GTK_ACCEL_VISIBLE);
210 } 210 }
211 211
212 browser_->command_updater()->AddCommandObserver(it->first, this); 212 browser_->command_updater()->AddCommandObserver(it->first, this);
213 } 213 }
214 214
215 // Listen for bookmark bar visibility changes and set the initial state. 215 // Listen for bookmark bar visibility changes and set the initial state.
216 registrar_.Add(this, NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED, 216 registrar_.Add(this, chrome::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
217 NotificationService::AllSources()); 217 NotificationService::AllSources());
218 Observe(NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED, 218 Observe(chrome::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
219 NotificationService::AllSources(), 219 NotificationService::AllSources(),
220 NotificationService::NoDetails()); 220 NotificationService::NoDetails());
221 } 221 }
222 222
223 GlobalMenuBar::~GlobalMenuBar() { 223 GlobalMenuBar::~GlobalMenuBar() {
224 for (CommandIDMenuItemMap::const_iterator it = id_to_menu_item_.begin(); 224 for (CommandIDMenuItemMap::const_iterator it = id_to_menu_item_.begin();
225 it != id_to_menu_item_.end(); ++it) { 225 it != id_to_menu_item_.end(); ++it) {
226 browser_->command_updater()->RemoveCommandObserver(it->first, this); 226 browser_->command_updater()->RemoveCommandObserver(it->first, this);
227 } 227 }
228 228
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 gtk_widget_show(menu_item); 295 gtk_widget_show(menu_item);
296 return menu_item; 296 return menu_item;
297 } 297 }
298 298
299 void GlobalMenuBar::EnabledStateChangedForCommand(int id, bool enabled) { 299 void GlobalMenuBar::EnabledStateChangedForCommand(int id, bool enabled) {
300 CommandIDMenuItemMap::iterator it = id_to_menu_item_.find(id); 300 CommandIDMenuItemMap::iterator it = id_to_menu_item_.find(id);
301 if (it != id_to_menu_item_.end()) 301 if (it != id_to_menu_item_.end())
302 gtk_widget_set_sensitive(it->second, enabled); 302 gtk_widget_set_sensitive(it->second, enabled);
303 } 303 }
304 304
305 void GlobalMenuBar::Observe(NotificationType type, 305 void GlobalMenuBar::Observe(int type,
306 const NotificationSource& source, 306 const NotificationSource& source,
307 const NotificationDetails& details) { 307 const NotificationDetails& details) {
308 DCHECK(type.value == NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED); 308 DCHECK(type == chrome::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED);
309 309
310 CommandIDMenuItemMap::iterator it = 310 CommandIDMenuItemMap::iterator it =
311 id_to_menu_item_.find(IDC_SHOW_BOOKMARK_BAR); 311 id_to_menu_item_.find(IDC_SHOW_BOOKMARK_BAR);
312 if (it != id_to_menu_item_.end()) { 312 if (it != id_to_menu_item_.end()) {
313 PrefService* prefs = browser_->profile()->GetPrefs(); 313 PrefService* prefs = browser_->profile()->GetPrefs();
314 314
315 block_activation_ = true; 315 block_activation_ = true;
316 gtk_check_menu_item_set_active( 316 gtk_check_menu_item_set_active(
317 GTK_CHECK_MENU_ITEM(it->second), 317 GTK_CHECK_MENU_ITEM(it->second),
318 prefs->GetBoolean(prefs::kShowBookmarkBar)); 318 prefs->GetBoolean(prefs::kShowBookmarkBar));
319 block_activation_ = false; 319 block_activation_ = false;
320 } 320 }
321 } 321 }
322 322
323 void GlobalMenuBar::OnItemActivated(GtkWidget* sender) { 323 void GlobalMenuBar::OnItemActivated(GtkWidget* sender) {
324 if (block_activation_) 324 if (block_activation_)
325 return; 325 return;
326 326
327 int id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(sender), "command-id")); 327 int id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(sender), "command-id"));
328 browser_->ExecuteCommandIfEnabled(id); 328 browser_->ExecuteCommandIfEnabled(id);
329 } 329 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698